Skip to content

USE-551: Applying secondary link styling to purple visited links#399

Merged
djanelle-mit merged 2 commits into
mainfrom
use-551
Jun 5, 2026
Merged

USE-551: Applying secondary link styling to purple visited links#399
djanelle-mit merged 2 commits into
mainfrom
use-551

Conversation

@djanelle-mit
Copy link
Copy Markdown
Contributor

@djanelle-mit djanelle-mit commented Jun 2, 2026

Developer

After adding source links to result metadata, the links often showed up as purple visited links since they were commonly our website or tools.

I went into this work hoping to apply a global style, but a lot of the rules applying magenta to visited links have more specificity than a global rule probably should have.

This work instead:

  • Fixes the magenta source link styling
  • Adds a secondary subtle underlined link style
  • Also applies this style to contributors to make all links in metadata have obvious visual affordance.
Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@djanelle-mit djanelle-mit changed the title USE-551: new secondary link mixin and applying to result metadata USE-551: Applying secondary link styling to purple visited links Jun 2, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 2, 2026

Coverage Report for CI Build 26895581337

Coverage remained the same at 98.319%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1428
Covered Lines: 1404
Line Coverage: 98.32%
Coverage Strength: 75.09 hits per line

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-551-3gg6q7icy June 2, 2026 15:05 Inactive
@djanelle-mit djanelle-mit requested review from JPrevost, jazairi and matt-bernhardt and removed request for JPrevost, jazairi and matt-bernhardt June 3, 2026 12:20
@mitlib mitlib temporarily deployed to timdex-ui-pi-use-551-3gg6q7icy June 3, 2026 15:37 Inactive
@JPrevost JPrevost self-assigned this Jun 5, 2026
@djanelle-mit djanelle-mit merged commit b06d206 into main Jun 5, 2026
6 checks passed
@djanelle-mit djanelle-mit deleted the use-551 branch June 5, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants